Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabric Support #321

Open
mrh0 opened this issue Aug 23, 2022 · 7 comments
Open

Fabric Support #321

mrh0 opened this issue Aug 23, 2022 · 7 comments
Labels
fabric good first issue Good for newcomers

Comments

@mrh0
Copy link
Owner

mrh0 commented Aug 23, 2022

While I (MRH0) support and maintain the Forge version of Create Crafts & Additions I do not support nor maintain the Fabric port.
The Fabric branch is community driven and I only approve changes, compile, and publish the jar. If anyone has an interest in maintaining the Fabric branch you are free to do so by making a PR here.

@mrh0 mrh0 added good first issue Good for newcomers fabric labels Aug 23, 2022
@mrh0 mrh0 pinned this issue Aug 23, 2022
@ajh123
Copy link

ajh123 commented Nov 24, 2022

You may have a look at Architectury. It allows you to use the same code for both Forge and Fabric.
You can also have Forge and Fabric specific code for working with some libraries. It will take some effort to transfer to project to it, and it will mean another dependency is needed (which we need to wait for to update to another MC version e.g. 1.20).
But this means we can have very little code for Fabric and Forge in the same branch and have a common library.
For an example my mod BetterCC uses it.

@Random-Cookie
Copy link

Just created #411
This is for fabric for 1.19.2 as diamond grit is not currently craftable.

@Sewdohe
Copy link

Sewdohe commented Jan 24, 2023

Could we get a contributor guide? I want to fix some crafting issues with fabric but I can't get the project to build in eclipse.

EDIT: running gradlew build hangs on 100% configuring for me

<=============> 100% CONFIGURING [1m 35s]
> Resolve dependencies of :runtimeClasspathCopy

@Sewdohe
Copy link

Sewdohe commented Jan 24, 2023

Okay: I had found a bug for Fabric where biomass couldn't be made due to the recipe including a forge tag...so I changed the identifter to just be seed oil rather than any kind of biofuel and it's working now - but is this an okay way of doing things? This break forge compat and I'm not sure if splitting the codebase so much from forge version was a good idea

@KLONOA9X6
Copy link

Is it possible to using Porting Lib?

@mrh0
Copy link
Owner Author

mrh0 commented Jun 1, 2023

Is it possible to using Porting Lib?

Not familiar with it, you mean for using it to port CC&A to fabric? sure. not sure if anyone else is working on a new fabric port atm

@dragonshardz
Copy link

dragonshardz commented Jul 1, 2023

#591 and #593 are both working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants