Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate existing tests to pytest from unittest. #80

Closed
mrhappyasthma opened this issue Jul 1, 2024 · 2 comments · Fixed by #81
Closed

Migrate existing tests to pytest from unittest. #80

mrhappyasthma opened this issue Jul 1, 2024 · 2 comments · Fixed by #81

Comments

@mrhappyasthma
Copy link
Owner

Existing tests are not running as part of the github actions. I believe it's because I implemented them using unittest and we are now using pytest (which seems to be the preferred options from some googling).

kocielnik added a commit to kocielnik/IsThisStockGood that referenced this issue Jul 2, 2024
@kocielnik
Copy link
Contributor

kocielnik commented Jul 2, 2024

Good note!

I actually should've included the line python run_all_tests.py in the new GitHub Actions config, because it was there in the CircleCI config.

I don't think migrating to PyTest is required to get these tests to work.

While it's not required, I do think it will unify the test logic.

Before we migrate to PyTest, we make sure some tests (not only "API" ones) run at all for incoming PRs.

That was my goal in #81.

@kocielnik
Copy link
Contributor

My, that was quick.

Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants