Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds toml to requirements.txt #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NishanthJKumar
Copy link

This is necessary to allow this action to work with projects that have a pyproject.toml at their root.

Should resolve #30

Copy link
Owner

@mritunjaysharma394 mritunjaysharma394 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick PR @NishanthJKumar, have you tested it on your fork ( i guess actions can be enabled in forks?)
The change looks good but just wanted to make sure it works (it shoud most probably but just wanted to make sure :)))

@NishanthJKumar
Copy link
Author

Will test on my fork and get back to you!

@NishanthJKumar
Copy link
Author

@mritunjaysharma394 - I was able to trigger the workflow on my fork here, but it seems to be running v1.0.2 of your action. I'm not sure how to test my change, can you give some guidance? or maybe you can trigger the changed workflow run on this repo instead of the fork?

@NishanthJKumar
Copy link
Author

One option is to try merging this and if there's an issue, you can undo the merge commit and revert the repo to its previous state?

@jiuguangw
Copy link

Hi @mritunjaysharma394 - any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action not working for projects using pyproject.toml
3 participants