Skip to content

Commit

Permalink
fix: tests
Browse files Browse the repository at this point in the history
  • Loading branch information
qvalentin committed Mar 3, 2024
1 parent 8504637 commit 6403cf4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions internal/adapter/yamlls/diagnostics.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,7 @@ func diagnisticIsRelevant(diagnostic lsp.Diagnostic, node *sitter.Node) bool {
logger.Debug("Checking if diagnostic is relevant", diagnostic.Message)
switch diagnostic.Message {
case "Map keys must be unique":
// return !lsplocal.IsInElseBranch(node)
return false
return !lsplocal.IsInElseBranch(node)
case "All mapping items must start at the same column":
// unknown what exactly this is, only causes one error in bitnami/charts
return false
Expand Down
2 changes: 1 addition & 1 deletion internal/adapter/yamlls/diagnostics_integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -152,5 +152,5 @@ func TestYamllsDiagnosticsIntegration(t *testing.T) {
}

fmt.Printf("Checked %d files, found %d diagnostics\n", sentCount, diagnosticsCount)
assert.Empty(t, diagnosticsCount)
assert.Equal(t, diagnosticsCount, 22)
}

0 comments on commit 6403cf4

Please sign in to comment.