Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace native/web features with platform-specific dependencies once Rust 1.51.0 releases #5

Closed
daboross opened this issue Jan 6, 2021 · 1 comment

Comments

@daboross
Copy link

daboross commented Jan 6, 2021

With the new feature resolver stabilizing in 1.51.0, we should be able to get rid of native and web features, and instead use something like:

[target.'cfg(target_arch = "wasm32)'.dependencies]
bevy = {version = "0.4.0", default-features=false}
bevy_webgl2 = {version="0.4.0", optional=true}

[target.'cfg(not(target_arch = "wasm32"))'.dependencies]
bevy = {version="0.4.0", default-features=false, features = ["bevy_wgpu"]}

I'd like to submit a PR for this, but it won't work until the itarget feature part of RFC 2957 is stabilized, which as of rust-lang/cargo#8997 will be Rust 1.51.0.

@mrk-its
Copy link
Owner

mrk-its commented Nov 9, 2021

done

@mrk-its mrk-its closed this as completed Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants