Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tainting with 118697 #4

Open
tflo opened this issue Aug 7, 2022 · 2 comments
Open

Tainting with 118697 #4

tflo opened this issue Aug 7, 2022 · 2 comments

Comments

@tflo
Copy link

tflo commented Aug 7, 2022

I had to deactivate 118697 (“Big Bag of Pet Supplies”) because it repeatedly triggered a taint error.

Thanks for this very handy addon! Besides that one container, it works flawlessly.

– Tom

Edit: 184866 (“Grummlepouch”) also produces taint.
Edit II: Also 122535 (“Traveler’s Pet Supplies”)

@tflo
Copy link
Author

tflo commented Aug 7, 2022

PS:

I just noticed that apparently I have to disable the container on each of my 16 toons separately! So, it is faster to batch-edit the SavedVariables files with my text editor. But then I don’t need an in-game GUI at all.

Please make the settings global, and not per-char. It was already fancy to have to disable the minimap button 16 times, but this is a bit too much now 🤕

@tflo
Copy link
Author

tflo commented Aug 8, 2022

PS II:

Here a quick fix for the SavedVariables issue:

Main.lua

Line 36:

Change

local defaults = {
    char = {}
}

to

local defaults = {
    profile = {}
}

Line 39:

Change

defaults.char[dbVersion] = {

to

defaults.profile[dbVersion] = {

and then search-replace all db.char[ with db.profile[ throughout the whole file.


This works because you already have assigned the "Default" profile to every char (see the profileKeys table in the SavedVar file). You just haven’t used it.

Later on, in the case you introduce a setting where you think it absolutely has to be char-specific, you can still allow the user to set a specific profile for a char. This will then be registered in the profileKeys table (instead of "Default"). – Or you use char for that particular setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant