Fix: Graph widget colour not synced (#63)

* fix: graph widget colour not synced * refactor: clean up code
mrmagic2020 · Jun 21, 2024 · e9b058e · e9b058e
1 parent 0346abc
commit e9b058e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/ui/generic/windows/graph.ts b/src/ui/generic/windows/graph.ts
@@ -91,7 +91,7 @@ class GraphWindow extends Window<WindowParams> {
           whiskerLow: read(params.statistics).min,
           whiskerHigh: read(params.statistics).max,
           range: params.boxChartRange,
-          background: baseData.global.colour_scheme.secondary.store.get()
+          background: baseData.global.colour_scheme.secondary.store
         })
       ],
       onClose: () => {

diff --git a/src/ui/generic/windows/window.ts b/src/ui/generic/windows/window.ts
@@ -6,13 +6,15 @@ import {
   window
 } from "openrct2-flexui"
 
-class Window<T extends WindowParams | TabWindowParams> {
+type AnyWindowParams = WindowParams | TabWindowParams
+
+class Window<T extends AnyWindowParams> {
   protected _windowParams: T
   protected _windowTemplate: WindowTemplate
   protected _isOpen: boolean
 
   private isTabWindowParams(
-    params: WindowParams | TabWindowParams
+    params: AnyWindowParams
   ): params is TabWindowParams {
     return (params as TabWindowParams).tabs !== undefined
   }
@@ -61,7 +63,7 @@ class Window<T extends WindowParams | TabWindowParams> {
     this.open()
   }
 
-  setProperties(properties: Partial<WindowParams>) {
+  setProperties(properties: Partial<AnyWindowParams>) {
     this._windowParams = { ...this._windowParams, ...properties }
   }
 }