-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selectbox #9
Comments
It's implemented the way it is because the library it's based off of did it this way. Much of the implementation is a straight translation of that code. There's no specific reason not to use a selctbox. If you have a better implementation, send a pull request. I'd be happy to look at it. |
Fairly simple solution to make it act like a select: Add a readonly property to the input that you are applying the library to Add a function to set the
Call the |
Thanks, @invalidusernam3, that sounds like a pretty elegant way of making it work like @NamPNQ wants it to. I like that it solves the problem of letting others allow their users to type directly into the field to find what they're looking for, but also makes it simple to change the behavior for a different use case if desired. Would you like to submit a pull request to make your suggested solution an option built into the library? You could trigger a call to a function like the |
No problem @mrmarkfrench, I'll clean it up a bit and submit a pull request tomorrow after work. I might also do the setting of the country name (from the select) on the input after the user has selected a country (as mentioned in one of the issues) |
Why we not use selectbox instead of input field
The text was updated successfully, but these errors were encountered: