Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization support for constants #79

Open
2 tasks done
Lewiscowles1986 opened this issue Jan 23, 2021 · 0 comments
Open
2 tasks done

Localization support for constants #79

Lewiscowles1986 opened this issue Jan 23, 2021 · 0 comments

Comments

@Lewiscowles1986
Copy link
Contributor

Is your feature request related to a problem? Please describe.

While working on #77 I introduced a constant to the library, which would embed English within the component. For non-English speakers this might represent a problem, or inconsistency with the announced highlighted option.

Describe the solution you'd like

Ideally for the problem introduced, a new piece of state could be introduced to allow user-supplied values for these constants, which have default values.

Describe alternatives you've considered

Library locale aware

The library could become locale aware, and locale could be sent in as state.

This might help other efforts, such as requesting localized results from a remote server. As user-js is needed to bootstrap plete, this was already possible, and might be something for Plete to avoid.

Differentiation of highlighted items could be removed

#78 could remove the differentiation and just announce the item without a custom aria-label.

Motivation and involvement

  • I / My organization is willing to commit to development and maintenance of this feature / request
  • [] I / My organization wish to financially contribute to the development of this feature / request
  • This would be nice to have, but I wish to have no involvement

Proof of concept

There is not, but it's an optional configuration value passed around with state context.

Additional context

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant