Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote $@ and make $file and $files local in scmpuff init -s #54

Open
HaleTom opened this issue Oct 22, 2020 · 2 comments · May be fixed by #57
Open

Quote $@ and make $file and $files local in scmpuff init -s #54

HaleTom opened this issue Oct 22, 2020 · 2 comments · May be fixed by #57

Comments

@HaleTom
Copy link

HaleTom commented Oct 22, 2020 •
edited
Loading

As per title.

for local file in...

Also $@ is not quoted.

Would you consider running shellcheck over the codebase? (It would have picked up the $@ quoting.)
@HaleTom HaleTom changed the title Make $file and $files local in scmpuff init -s Quote $@ and make $file and $files local in scmpuff init -s Oct 22, 2020
@mroth
Copy link
Owner

mroth commented Oct 26, 2020

This makes a lot of sense, it should be possible to integrate shellcheck into the CI fairly easily with GitHub Actions.

@mroth mroth linked a pull request Dec 5, 2021 that will close this issue
Open
@mroth
Copy link
Owner

mroth commented Dec 6, 2021

@HaleTom I started addressing this in #57, if you wouldn't mind taking a look, I have some questions and would appreciate your input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build(ci): add shellcheck linting mroth/scmpuff
2 participants
@mroth @HaleTom