Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure Holding links to Opinions and Decisions #104

Open
mscarey opened this issue Jul 31, 2021 · 1 comment
Open

Restructure Holding links to Opinions and Decisions #104

mscarey opened this issue Jul 31, 2021 · 1 comment

Comments

@mscarey
Copy link
Owner

mscarey commented Jul 31, 2021

Instead, OpinionReading can have opinion_author and opinion_type attributes corresponding to the author and type found on the Opinion model. That way the Decision and OpinionReading don't both need to have the Opinion as attributes.

Decision.posit could take author and type parameters to pass the Holdings that need to be posited down to the proper OpinionReading (but if there's only one OpinionReading, those params could be omitted).

@mscarey
Copy link
Owner Author

mscarey commented Oct 24, 2021

I implemented the approach above, but I still don't like it. It's too easy for the OpinionReading to get out of sync with the Opinion, without a direct link to the Opinion. There must be a more intuitive way to organize or consolidate these classes (and the DecisionReading).

@mscarey mscarey changed the title OpinionReading should not have Opinion as attribute Restructure Holding links to Opinions and Decisions Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant