adapt to current Rack development version, and fix some issues en-passant #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing linebreak on line 8 stopped 'make dist' from completing.
Update Makefile
A run with "scan-build-6 make" on Linux (which uses Clang's static analyzer) found these dead assignments.
Clang's static analyzer noticed It turned out that finR wasn't initialized, but still used. Fix that.
Clang's static analyzer noticed that in the default case of the switch statement out[] wasn't initialized and that 2 lines below the uninitialized memory could have been used.
The first parameter of any *printf function should be should be a string literal. If you pass in some random string, then the %s, %p etc that might be in the random string will be interpreted, with whatever garbage is currently on the stack. We could now convert this to fwrite(), but just using the most simply string conversion seemed more simple, this isn't time critical code anyway.
|
@holgerschurig Hi Holger, only to inform you that I didn't proceeded with a PR as per this issue: #55 that was then closed by @cschol |
|
sorry guys, i missed this and submitted my 0.6 build |
mschack
force-pushed
the
master
branch
3 times, most recently
from
a76e772
to
0685100
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
after I did the adaption to the 0.6.0dev API, I found out by chance that dizzisound also did this. *) So it seems that people want compile your code against the newest-and-hottest (and buggiest, lol) Rack.
While I adapted the plugins, I also noticed some errors from my Linux GCC compiler. And while at it, I thought "Hey, let's throw clang's static analyzer onto the code". And it also found some things. I fixed all of them.
*) dizzisound@774f6dc ... he didn't create a pull request