Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream: unpacking '0' doesn't trigger 'msg' emit #44

Open
llint opened this issue Feb 11, 2018 · 0 comments
Open

Stream: unpacking '0' doesn't trigger 'msg' emit #44

llint opened this issue Feb 11, 2018 · 0 comments

Comments

@llint
Copy link

llint commented Feb 11, 2018

msgpack.js: line 73, it should be if (msg == null), instead of if (!msg) - if msg as unpacked correctly as 0, would silent the 'msg' emission. Please fix.

ps: is this project dead already? if there is no maintainer anymore, please consider transferring the repo ownership, so the community can hopefully keep it alive. Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@llint