Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement request] Have an integration with an Oauth provider to put the creator behind login/domain validation. #69

Open
erocheleau opened this issue Jan 16, 2020 · 2 comments

Comments

@erocheleau
Copy link

It would be awesome if I could plug this easily into something Auth0 for example to require users to authenticate with Google and only authorize my company's domain perhaps?

Since Heroku is kinda open to the entire world and that this allows to create scratch orgs which are a limited resource, it would be nice to be able to secure that app very easily once deployed. The Auth0 Heroku addon seemed like a good candidate for that I think and it would support tons of OAuth identity providers.

@mshanemc
Copy link
Owner

Have considered that option...a few other options would be to add IP restrictions (either in code or via heroku private spaces and just expose the web). Pretty sure one of the teams at Salesforce did something similar.

Are the people you're imagining not Salesforce users? Because authing to an org would also be an easy option since we already have jsforce on the deployer.

Any chance you'd want to contribute that part?

@erocheleau
Copy link
Author

erocheleau commented Jan 24, 2020

You mean having a Salesforce account, not Salesforce employees right?

I was going to try to do it with Auth0 in a fork but I tried forking and cloning the repo but the npm install didn't manage to run properly with an error (tried on windows/MAC) on node 10.15 OR 12.13.1 OR 9.

npm WARN deprecated @types/[email protected]: This is a stub types definition. dotenv provides its own type definitions, so you do not need this installed.
npm WARN deprecated [email protected]: This module has moved and is now available at @rollup/plugin-replace. Please update your dependencies. This version is no longer maintained.
npm WARN deprecated @types/[email protected]: This is a stub types definition. nock provides its own type definitions, so you do not need this installed.
npm WARN deprecated [email protected]: This package has been deprecated in favour of @sinonjs/samsam
npm WARN deprecated [email protected]: Browserslist 2 could fail on reading Browserslist >3.0 config used in other tools.
npm ERR! Cannot read property 'match' of undefined
npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/username/.npm/_logs/2020-01-16T19_30_14_526Z-debug.log```

I got that error every time and didn't have time to push further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants