Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json context manager #552

Open
dagraham opened this issue Jan 5, 2024 · 1 comment
Open

json context manager #552

dagraham opened this issue Jan 5, 2024 · 1 comment

Comments

@dagraham
Copy link

dagraham commented Jan 5, 2024

I've tried subclassing both Storage and JSONStorage and replacing their read and write methods with ones that use context management but it seems that neither are being actually used even though the subclassed storage classes seem to be loaded. Where am I going wrong? Help please.

I'm trying this because of an endless stream of:
Exception ignored in: <_io.FileIO name='/Users/dag/etm-test/etm.json' mode='rb+' closefd=True>
ResourceWarning: unclosed file <_io.TextIOWrapper name='/Users/dag/etm-test/etm.json' mode='r+' encoding='UTF-8'>

@msiemens
Copy link
Owner

msiemens commented Oct 7, 2024

Hey @dagraham, is this still relevant to you? If so, could you post a short example that reliably reproduces the problem you're having?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants