From 55df0c016adea899d475c0e9db76039cae7a01ca Mon Sep 17 00:00:00 2001 From: ao508 <15623749+ao508@users.noreply.github.com> Date: Tue, 18 Jun 2024 14:19:04 -0400 Subject: [PATCH] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 19d616e6..3f9aebbc 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -34,13 +34,6 @@ Please follow these checklists to help prevent any unexpected issues from being Please follow these checks if any changes were made to any classes in the web, service, or persistence layers. -**Data checks:** -Updates were made to the mocked incoming request data and/or mocked published request data: -- [ ] [smile-server test data](https://github.com/mskcc/smile-server/tree/master/service/src/test/resources/data) -- [ ] [smile-commons test data](https://github.com/mskcc/smile-commons/tree/master/src/test/resources/data) -- [ ] [smile-label-generator test data](https://github.com/mskcc/smile-label-generator/tree/master/src/test/resources/data) -- [ ] [smile-request-filter test data](https://github.com/mskcc/smile-request-filter/tree/master/src/test/resources/data) - **Code checks:** - [ ] Endpoints were tested to ensure their integrity. - [ ] Screenshots have been provided to demonstrate changes made to the response body JSON schema and/or swagger page. @@ -70,8 +63,8 @@ Other: [insert details on how messages were published or simulated for testing] ### IV. Configuration and/or permissions checklist: - [ ] New topics were introduced. -- [ ] The topics and appropriate permissions were updated in [cmo-metadb-configuration](https://github.mskcc.org/cmo/cmo-metadb-configuration). -- [ ] If applicable, a new account was set up and the account credentials and keys are checked into [cmo-metadb-configuration](https://github.mskcc.org/cmo/cmo-metadb-configuration). +- [ ] The topics and appropriate permissions were updated in [smile-configuration](https://github.mskcc.org/cmo/smile-configuration). +- [ ] If applicable, a new account was set up and the account credentials and keys are checked into [smile-configuration](https://github.mskcc.org/cmo/smile-configuration). - [ ] Account credentials and keys were shared with the appropriate parties. ---