Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix obs.mat feature of fitcn #71

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix obs.mat feature of fitcn #71

wants to merge 4 commits into from

Conversation

ShaiberAlon
Copy link
Collaborator

@ShaiberAlon ShaiberAlon commented Dec 13, 2021

  1. Had to change cbind/rbind -> cbind2/rbind2
  2. trim the solution after optimization to remove the rows that were added due to obs.mat
  3. unrelated to fitcn: added `%+%` = gUtils::`%+%` to apps.R because otherwise sometimes (depending on library include order) the ggplot %+% is used instead of the gUtils.
  4. only setting 'grl.labelfield'to "name" if it was not supplied already as a metadata field

cbind2

I honestly don't understand why cbind doesn't work, but it doens't. cbind is supposed to recursively call cbind2, but it doesn't seem to do so. This is quite annoying because cbind2 only works on two matrixes so we need to explicitly call it recursively each time on a pair of matrixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant