Time picker UI not reflecting actual element value

[Simopich]

Hi, first of all, thanks for the great library!

I've just encountered a problem while using the time picker.
I have a variable bound to the picker element that has value "02:25", so the UI shows something like this:

Now, if I change the hour to, let's say, "11", the UI changes to become like this:

It already shows the minutes as selected, so the users could think that the current variable value is "11:25", but it's not!
It's still "02:25" until you select the minutes again, so you'd need to press the already selected minute "25" if you want to actually update the variable value.

I think the most logical option would be a variable update when you change the hour too, but let me know what you think!

Thanks again,
Simone.

[mskocik]

Can you past simple example in REPL?

[Simopich]

Sure, I just noticed that this happens only in pickerOnly mode.
REPL here

[mskocik]

When you set autocommit={false} then the behaviour is clear, because you need to press OK button to confirm new selection. Without it... it's probably bug, but I thought I consider this use-case as well. Will need to look into it deeper. And hopefully I will remember, why it's done the way it is 😄

[Simopich]

I may have found another bug that seems to be related to this in the time picker with the following options: pickerOnly, isRange, autocommit set to false.

If you choose an hour (hour only, no minutes selected) in the first time picker greater than the second one and press OK, the UI shows a completely wrong state that doesn't reflect the variable value.

Example:

I've set the initial picker value to: ["02:25", "16:40"]

If you press "17" in the first picker and click OK, the UI shows "40" as the selected minute in the first picker but the actual variable value becomes "17:25", which I think is inconsistent (And the same thing automatically occurs in the second picker, the hour changes in the UI because the first time can't be greater than the second one but the actual variable value stays at "16:40").

What do you think?

REPL

[mskocik]

Definitely a bug, it seems, that internal dates are "swapped" at some point, when editing first time.