Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Controller #8

Open
AlexKempen opened this issue Feb 28, 2023 · 1 comment
Open

Implement Controller #8

AlexKempen opened this issue Feb 28, 2023 · 1 comment
Assignees

Comments

@AlexKempen
Copy link
Member

We should update the implementation of controller to include all of the necessary functionality.
We updated the controller interface; now we need to update the hardware::ProsController implementation to properly implement the added methods, passing through the relevant pros methods. Use switch statements to map the various enums to the corresponding methods in pros::Controller. See the switch statements in pros_motor_cartridge for examples.

We should also move the two factory methods which generate controller (MakeDriverController and MakeSecondaryController) from ProsController to a new file in factory. They don't need to be in their own explicit class (since namespacing provides a shared scope for them by default).

@AlexKempen
Copy link
Member Author

Also, be sure to work on this issue in a branch, not in holonomic-drive directly. You can create a branch for this issue in the right panel (just don't forget to change the branch source from main to holonomic-drive).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants