Code

WIP: Refactor#72

Code

Closed

j-maas wants to merge 60 commits intomswart:mastermswart/openmensa-parsers:masterfrom j-maas:aachen-alternate-websitej-maas/openmensa-parsers:aachen-alternate-websiteCopy head branch name to clipboard

+2,631-142

Commits

Commits on Jan 14, 2018

• Add regression test

  

  Y0hy0h

  committed
  015a38b

  Copy full SHA for 015a38b

• Create aachen package and move parser file and tests into it

  

  Y0hy0h

  committed
  fb7c4f8

  Copy full SHA for fb7c4f8

• Fix aachen_test.py import and rename to regression_test.py

  

  Y0hy0h

  committed
  4615e5c

  Copy full SHA for 4615e5c

• Test parsers/ on build

  

  Y0hy0h

  committed
  f909889

  Copy full SHA for f909889

• Make XML output deterministic

  

  Y0hy0h

  committed
  fd8547e

  Copy full SHA for fd8547e

Commits on Jan 19, 2018

• Base regression test on snapshots

  

  Y0hy0h

  committed
  b235233

  Copy full SHA for b235233

• Update .gitignore to exclude virtual environment directories

  

  Y0hy0h

  committed
  8f15ab7

  Copy full SHA for 8f15ab7

• Determine parser's URL programmatically

  

  Y0hy0h

  committed
  dc8cc32

  Copy full SHA for dc8cc32

• Make regression tests generic

  

  Y0hy0h

  committed
  1727544

  Copy full SHA for 1727544

• Flatten Aachener parser package

  Show description for 0c963c1
  

  Y0hy0h

  committed
  0c963c1

  Copy full SHA for 0c963c1

• Print feedback when updating snapshots

  

  Y0hy0h

  committed
  0172252

  Copy full SHA for 0172252

• Add missing build dependency

  

  Y0hy0h

  committed
  65c2b26

  Copy full SHA for 65c2b26

Commits on Jan 21, 2018

• Make regression test independent of request-mock package

  

  Y0hy0h

  committed
  d673ff6

  Copy full SHA for d673ff6

• Remove unneeded build dependency

  

  Y0hy0h

  committed
  12adcc4

  Copy full SHA for 12adcc4

• Add copyable output on failed regression test

  

  Y0hy0h

  committed
  39ef9c7

  Copy full SHA for 39ef9c7

• Respect encoding during snapshot upgrade

  

  Y0hy0h

  committed
  626ce6b

  Copy full SHA for 626ce6b

Commits on Jan 22, 2018

• Only allow snapshot updates for individual canteens

  

  Y0hy0h

  committed
  c8f11fc

  Copy full SHA for c8f11fc

• Allow updates of all parsers-under-test' snapshots with flag

  

  Y0hy0h

  committed
  a8e1538

  Copy full SHA for a8e1538

Commits on Jan 24, 2018

• Use upstream PyOpenMensa determinism instead of workaround

  

  Y0hy0h

  committed
  ad40add

  Copy full SHA for ad40add

Commits on Feb 4, 2018

• Detect URL's to store as snapshots automatically

  

  Y0hy0h

  committed
  9078f01

  Copy full SHA for 9078f01

• Update snapshots for Aachen

  

  Y0hy0h

  committed
  f3d1dc0

  Copy full SHA for f3d1dc0

Commits on Feb 6, 2018

• Use unittest.mock for intercepting requests

  

  Y0hy0h

  committed
  acd931e

  Copy full SHA for acd931e

• Fix HTTP requests not being intercepted

  

  Y0hy0h

  committed
  811d3b6

  Copy full SHA for 811d3b6

• Pretty print website snapshot

  

  Y0hy0h

  committed
  ff43e5d

  Copy full SHA for ff43e5d

• Fix Aachener usage of requests for testability

  

  Y0hy0h

  committed
  519ac05

  Copy full SHA for 519ac05

• Update snapshots

  

  Y0hy0h

  committed
  ecce574

  Copy full SHA for ecce574

• Refactor Aachener parser

  

  Y0hy0h

  committed
  ff3fa65

  Copy full SHA for ff3fa65

• Use model for Meal

  

  Y0hy0h

  committed
  663f8eb

  Copy full SHA for 663f8eb

• Use model for table entry

  

  Y0hy0h

  committed
  e7ccc7b

  Copy full SHA for e7ccc7b

• Add model for category

  

  Y0hy0h

  committed
  af1f8f0

  Copy full SHA for af1f8f0

• Refactor Aachener methods

  

  Y0hy0h

  committed
  3700e45

  Copy full SHA for 3700e45

• Move up side effects

  

  Y0hy0h

  committed
  a618997

  Copy full SHA for a618997

• Reduce use of LazyBuilder and fix model

  

  Y0hy0h

  committed
  140c38b

  Copy full SHA for 140c38b

• Remove docstrings

  

  Y0hy0h

  committed
  c263bb8

  Copy full SHA for c263bb8

• Move conversions from model to user

  

  Y0hy0h

  committed
  0740615

  Copy full SHA for 0740615

• Fix category ordering

  

  Y0hy0h

  committed
  8e57932

  Copy full SHA for 8e57932

• Use model-based XML generation

  

  Y0hy0h

  committed
  2c45b52

  Copy full SHA for 2c45b52

• Move error handling up

  

  Y0hy0h

  committed
  4d055cc

  Copy full SHA for 4d055cc

• Remove unused LazyBuilder code

  

  Y0hy0h

  committed
  cefb263

  Copy full SHA for cefb263

• Move aachen into own package, implement legend parsing for new website

  

  Y0hy0h

  committed
  ba0c5c7

  Copy full SHA for ba0c5c7

• Move Aachen to own package, implement parsing for alternate website

  

  Y0hy0h

  committed
  e8d1ab5

  Copy full SHA for e8d1ab5

• Implement equality for model and rename feed_model to openmensa_model

  

  Y0hy0h

  committed
  c754b1b

  Copy full SHA for c754b1b

• Fix parser bugs

  

  Y0hy0h

  committed
  7567911

  Copy full SHA for 7567911

• Refactor OpenMensa model for encapsulation

  

  Y0hy0h

  committed
  00f4667

  Copy full SHA for 00f4667

Commits on Feb 8, 2018

• Make Aachener model hashable

  

  Y0hy0h

  committed
  6bfddcf

  Copy full SHA for 6bfddcf

• Determine available categories programmatically

  

  Y0hy0h

  committed
  2b635fe

  Copy full SHA for 2b635fe

• Filter out meals containing unavailability disclaimer

  

  Y0hy0h

  committed
  8cd88bb

  Copy full SHA for 8cd88bb

• Handle closed days

  

  Y0hy0h

  committed
  be1d9e4

  Copy full SHA for be1d9e4

• Update Aachener snapshots

  

  Y0hy0h

  committed
  e42d8c7

  Copy full SHA for e42d8c7

• Defend against whitespace terrorism

  

  Y0hy0h

  committed
  28a46ed

  Copy full SHA for 28a46ed

• Factor Aachen into smaller methods

  

  Y0hy0h

  committed
  47000db

  Copy full SHA for 47000db

• Refactor Aachener parser for readability

  

  Y0hy0h

  committed
  b691a12

  Copy full SHA for b691a12

• Export openmensa_model in setup.py

  

  Y0hy0h

  committed
  6dd874d

  Copy full SHA for 6dd874d

• Use OrderedCounter

  

  Y0hy0h

  committed
  911960c

  Copy full SHA for 911960c

• Make OpenMensa Price closer to XML, replace it with Aachener model

  

  Y0hy0h

  committed
  22f3d99

  Copy full SHA for 22f3d99

• Allow complete initialization of OpenMensa model objects

  

  Y0hy0h

  committed
  11a48ef

  Copy full SHA for 11a48ef

• Offload conversion from custom to OpenMensa model from parser to model objects

  

  Y0hy0h

  committed
  9a20377

  Copy full SHA for 9a20377

• Move local ignored folders out of .gitignore

  Show description for b61d956
  

  Y0hy0h

  committed
  b61d956

  Copy full SHA for b61d956

• Rename OpenMensa model's DayClosed to ClosedDay

  

  Y0hy0h

  committed
  d4880a3

  Copy full SHA for d4880a3

• Fix Aachener model import

  

  Y0hy0h

  committed
  87c3572

  Copy full SHA for 87c3572