New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

venv/scripts/nt scripts are not installed #169

Open

lazka opened this issue Mar 18, 2024 · 2 comments

Member

lazka commented Mar 18, 2024 •

edited

Loading

The .bat activate files are not installed and thus don't end up in venvs. So activating from cmd isn't possible

Maybe it needs to be added here https://github.com/python/cpython/blob/a9c304cf020e2fa3ae78fd88359dfc808c9dd639/Makefile.pre.in#L2301 ?

Member Author

lazka commented Aug 5, 2024

Related, some code assumes that "Scripts" exists in venvs: https://github.com/pre-commit/pre-commit/blob/8a3ee454a2e1617d1896b12beeb6152d6582638f/pre_commit/languages/python.py#L51

msys2/MINGW-packages#21574

lazka mentioned this issue

python-pre-commit: Fix installation of python pre-commit hooks msys2/MINGW-packages#21574

Merged

Member

naveen521kk commented Aug 6, 2024

So are you suggesting having both the Scripts and bin directories for venvs for better compatibility?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment