Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util.find_msvcrt() shouldn't return anything for ucrt #17

Closed
lazka opened this issue Jul 23, 2021 · 1 comment · Fixed by #19
Closed

util.find_msvcrt() shouldn't return anything for ucrt #17

lazka opened this issue Jul 23, 2021 · 1 comment · Fixed by #19

Comments

@lazka
Copy link
Member

lazka commented Jul 23, 2021

upstream doesn't either, and we return the wrong name for ucrt builds which makes some tests fail

https://bugs.python.org/issue23606

_get_build_version() should be ignored.

@lazka
Copy link
Member Author

lazka commented Jul 25, 2021

Fixed in #19

@lazka lazka changed the title util.find_msvcrt() shouldn't return anything util.find_msvcrt() shouldn't return anything for ucrt Jul 25, 2021
@lazka lazka closed this as completed in #19 Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant