Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when placing slopes #2

Closed
redblade7 opened this issue Oct 3, 2023 · 7 comments
Closed

Crash when placing slopes #2

redblade7 opened this issue Oct 3, 2023 · 7 comments
Labels
invalid This doesn't seem right

Comments

@redblade7
Copy link

redblade7 commented Oct 3, 2023

Hi,

I've been having crashes on one of my servers when players place down sloped wood. Here's an example log:

2023-10-03 13:30:25: ACTION[Server]: (REMOVED) places node coloredwood:slope_wood_grey at (-4330,18,-13166)
2023-10-03 13:30:27: ACTION[Main]: Server: Shutting down
2023-10-03 13:30:27: ACTION[Server]: (REMOVED) leaves game. List of players: 
2023-10-03 13:30:29: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'coloredwood' in callback item_OnPlace(): ...ames/minetest_game/mods/moreblocks/stairsplus/common.lua:77: attempt to perform arithmetic on a nil value
2023-10-03 13:30:29: ERROR[Main]: stack traceback:
2023-10-03 13:30:29: ERROR[Main]: 	...ames/minetest_game/mods/moreblocks/stairsplus/common.lua:77: in function <...ames/minetest_game/mods/moreblocks/stairsplus/common.lua:42>
@Niklp09
Copy link
Member

Niklp09 commented Oct 3, 2023

Maybe an issue of flux's moreblocks fork. I'll investigate this tomorrow.

@Niklp09 Niklp09 added the bug Something isn't working label Oct 3, 2023
@BuckarooBanzay
Copy link
Member

Maybe an issue of flux's moreblocks fork. I'll investigate this tomorrow.

i don't think they are on flux's fork, i didn't find any common.lua file here: https://github.com/fluxionary/minetest-moreblocks/tree/master/stairsplus

On the upstream repo it is though:
https://github.com/minetest-mods/moreblocks/blob/master/stairsplus/common.lua#L77C1-L77C35

@Niklp09
Copy link
Member

Niklp09 commented Oct 27, 2023

Moreblocks found a wrong (or unsupported) p2 in the node (pointed_thing) under the coloredwood node. Moreblocks misses a nil check for that IMO.

@redblade7
Copy link
Author

So you think this is a Moreblocks issue then and I should file a bug report there?

@Niklp09
Copy link
Member

Niklp09 commented Oct 29, 2023

So you think this is a Moreblocks issue then and I should file a bug report there?

Basically yes.

@redblade7
Copy link
Author

Filed a bug report: minetest-mods/moreblocks#201

@Niklp09
Copy link
Member

Niklp09 commented Apr 16, 2024

Closing, definitely a moreblocks issue.

@Niklp09 Niklp09 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 16, 2024
@Niklp09 Niklp09 added invalid This doesn't seem right and removed bug Something isn't working labels Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants