Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

digiline & stackwise filter injectors don't process "split" stacks #62

Open
fluxionary opened this issue Mar 8, 2023 · 2 comments
Open
Labels
bug Something isn't working

Comments

@fluxionary
Copy link
Member

i'm unsure whether this is a bug or more of a documentation issue.

if there's a full stack of items split amongst multiple slots in the "input" inventory, a stackwise filter injector will only send 1 stack at a time. given its name, that makes sense.

however, the digiline filter injector, when given input like the following from a luacontroller, will send nothing, despite a full stack being available:

digiline_send("injector", {
  exmatch = true,
  name = "default:chest",
  count = 99,
})
@S-S-X
Copy link
Member

S-S-X commented Mar 8, 2023

Also somewhat related issue #15 (early return: it does not process even complete stacks if there's partial too small stack before requested stack)

It is a bug and also discussed many times but it seems there's no dupe issue... there was one for sure back when repo was still on gitlab.

Whole inventory lookup should be refactored and optimizations added, automated injectors do waste significant amount of time looking through inventory.

Fixing this issue with some bubble gum shouldn't be too hard but I think nobody started it because adding more features without refactoring for optimizations would just make it even more complicated and in the end make refactoring even harder task...

Side note: I do remember that there was already a PR or at least a branch + discussion to "fix" this issue by removing "exmatch" option. Voiced my opinion against it back then and I do still think that exmatch option should stay and is useful or even required for some things.

@S-S-X S-S-X added the bug Something isn't working label Mar 8, 2023
@SwissalpS
Copy link
Contributor

related or duplicate of #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants