Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable Sonos support in mkchromecast #467

Open
xsdg opened this issue May 24, 2024 · 1 comment
Open

Re-enable Sonos support in mkchromecast #467

xsdg opened this issue May 24, 2024 · 1 comment

Comments

@xsdg
Copy link
Collaborator

xsdg commented May 24, 2024

Sonos support was implicitly disabled as part of the refactor in 40b3773 , because the way it was initially added harmed code readability, modularity, correctness, etc.

For anyone wanting Sonos support, you can use the stable branch, or check out a version of the codebase prior to that change.

The solution here is to finish refactoring cast.py (which has its own issues, even regarding Sonos), and then to re-incorporate Sonos support in a way that is sustainable for the codebase.

@psmgeelen
Copy link
Contributor

@xsdg let me know if I can support :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants