Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Menu] Trigger's default behavior cannot be prevented #1441

Open
michaldudak opened this issue Feb 13, 2025 · 0 comments · May be fixed by #1445
Open

[Menu] Trigger's default behavior cannot be prevented #1441

michaldudak opened this issue Feb 13, 2025 · 0 comments · May be fixed by #1445
Assignees
@michaldudak
Labels
bug 🐛 Something doesn't work component: menu This is the name of the generic UI component, not the React module!

Comments

@michaldudak
Copy link
Member

Calling preventBaseUIHandler in MenuTrigger's onMouseDown doesn't prevent the menu from opening.

Repro: https://codesandbox.io/p/sandbox/winter-cloud-7kyh2j?file=%2Fsrc%2FApp.tsx%3A7%2C16

This happens because events coming from Floating UI are not merged with mergeReactProps.
@michaldudak michaldudak added bug 🐛 Something doesn't work component: menu This is the name of the generic UI component, not the React module! labels Feb 13, 2025
@michaldudak michaldudak self-assigned this Feb 13, 2025
@michaldudak michaldudak linked a pull request Feb 14, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaldudak michaldudak

Labels
bug 🐛 Something doesn't work component: menu This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Menu] Fix prop merging issues michaldudak/base-ui
1 participant
@michaldudak