Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Popover] Port Component #6270

Closed
4 tasks done
stunaz opened this issue Mar 3, 2017 · 5 comments
Closed
4 tasks done

[Popover] Port Component #6270

stunaz opened this issue Mar 3, 2017 · 5 comments
Labels
component: Popover The React component.

Comments

@stunaz
Copy link
Contributor

stunaz commented Mar 3, 2017

  • Component
  • Tests (at least unit tests)
  • Demo
  • Docs
@Shahrukh-Zindani
Copy link

Shahrukh-Zindani commented Mar 3, 2017

I just saw that [Popover] component exists in the internal folder here https://github.com/callemall/material-ui/tree/next/src/internal. So the js file and the tests are already there. However Demo and Docs are missing. @oliviertassinari Can you confirm that the first two checkboxes can be checked and give a go-ahead on the last two tasks? Or is there a reason to have Popover in the internal folder and not with other components?

@Shahrukh-Zindani Shahrukh-Zindani self-assigned this Mar 4, 2017
@oliviertassinari
Copy link
Member

I would like that issue to #6218 where we discussed exposing internal component. The Popover is from my perspective an internal component that might be used outside of the Material specification.

@Shahrukh-Zindani You are right, I have checked the first two tasks. The question is more about the documentation/demo now. Those internal components solve problems on their own.

If we go forward, how could we do it?
We could create a new section in the documentation like, Internal Component Demos and document the properties. We don't do it right now.

I think that we should hold on #6218 conclusion to go further.

@oliviertassinari oliviertassinari added this to the v1.0.0-prerelease milestone Jul 4, 2017
@d-landes
Copy link

Hi @oliviertassinari, long time no see! The platform team here at Nokia Tech (ex Withings) says hi!

In our project, the Popover component allowed us to implement a couple of panels that can be expanded from the App Bar to display more detailed informations, links and calls to actions, without changing page. It's similar to Facebook's notification popover or this example taken from Gmail.
screenshot from 2017-07-24 16-18-14
I understand that you'd like to keep this component internal and unexposed, is there any other way that you'd recommend to implement such a feature? Using dialogs or drawers seems to go against the Material specs. Popover sure is a fairly low-level component as much as Paper for instance, but I think it could have its place in its API, in itself, or via a higher-level PopoverButton or a prop of the IconButton component or something. What do you think?

Cheers!

@oliviertassinari
Copy link
Member

@d-landes Hi old friend :p.

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 24, 2017

@d-landes Also, I'm happy to see that the team is moving away from backbone/marionette.js.

I have been experimenting with using Material-UI at work in order to build a non-material like design. That turns out to work well, so I believe there is value to move forward in the Naked UI direction and to officially expose this Popover component.

Given your use case, the component seems like a good fit, you can take advantage of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Popover The React component.
Projects
None yet
Development

No branches or pull requests

4 participants