-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Popover] Port Component #6270
Comments
I just saw that [Popover] component exists in the internal folder here https://github.com/callemall/material-ui/tree/next/src/internal. So the js file and the tests are already there. However Demo and Docs are missing. @oliviertassinari Can you confirm that the first two checkboxes can be checked and give a go-ahead on the last two tasks? Or is there a reason to have Popover in the internal folder and not with other components? |
I would like that issue to #6218 where we discussed exposing internal component. The @Shahrukh-Zindani You are right, I have checked the first two tasks. The question is more about the documentation/demo now. Those internal components solve problems on their own. If we go forward, how could we do it? I think that we should hold on #6218 conclusion to go further. |
Hi @oliviertassinari, long time no see! The platform team here at Nokia Tech (ex Withings) says hi! In our project, the Cheers! |
@d-landes Hi old friend :p. |
@d-landes Also, I'm happy to see that the team is moving away from backbone/marionette.js. I have been experimenting with using Material-UI at work in order to build a non-material like design. That turns out to work well, so I believe there is value to move forward in the Naked UI direction and to officially expose this Given your use case, the component seems like a good fit, you can take advantage of it. |
The text was updated successfully, but these errors were encountered: