Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[figma] Elevation colors are confusing, try to find another method #449

Open
mui-bot2 opened this issue Feb 1, 2025 · 2 comments
Open
Assignees
Labels
enhancement This is not a bug, nor a new feature figma

Comments

@mui-bot2
Copy link

mui-bot2 commented Feb 1, 2025

You have a new comment on Material UI for Figma (and MUI X)
Paul Whelan
Can I ask why the paper-elevation variables are is inside the background collection? Inside this collection you have 24 variables set to white, this kinda feels redundant and in the incorrect place especially considering you have setup a collection called 'elevation'.

Inside the 'elevation' collection you have created a single variable called 'outline'. What is the purpose of this?

In addition, Paper elevation is a style, correct? It's a drop shadow set in the styles panel so the variables set up are a bit confusing IMO. To apply elevation why are you proposing to add a variable (that only applies a colour) and a style to a frame... surely the style is enough. Just seem like an uanessacry step in the design process.
Reply to comment

Search keywords:

@mui-bot2 mui-bot2 added figma status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Feb 1, 2025
@adrianmanea
Copy link
Collaborator

adrianmanea commented Feb 3, 2025

Answered but I think there is an improvement here that can be done.

Hi @pwgsn the elevation of the paper has different background color on dark mode. We had to define those as variables so they can change based on the mode. Outline on the other hand is the same for both light and dark.
I absolutely get your point, having so many elevations defined while being all white (doesn't make sense, right?)—but we had to define them as long as the dark mode has different colors.
The API basically ads a layer with different opacity based on the elevation. I have an idea to simply define variables with the opacities of the elevation. That way we can stick with one color, I think. I may need to experiement.

@adrianmanea adrianmanea changed the title You have a new comment on Material UI for Figma (and MUI X) by Paul Whelan [figma] Elevation colors are confusing, try to find another method Feb 3, 2025
@adrianmanea adrianmanea removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Feb 3, 2025
@oliviertassinari
Copy link
Member

oliviertassinari commented Feb 3, 2025

palette.background.paper-elevation-* is kind of weird but I also get the rationale.
What confuses me though is palette.background.elevation.outline, I can't quite figure out the rule it follows, it feels random.

I could see us doing is to reorganize this:

  • palette.background.paper-elevation-* -> palette._components.paper.background-elevation-*
  • palette.background.elevation.outline -> palette._components.paper.outlineBorder (though palette.divider might be enough)

@oliviertassinari oliviertassinari added the enhancement This is not a bug, nor a new feature label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is not a bug, nor a new feature figma
Projects
None yet
Development

No branches or pull requests

3 participants