Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] Add a default background color to the data grid #15517

Open
KenanYusuf opened this issue Nov 20, 2024 · 1 comment
Open

[data grid] Add a default background color to the data grid #15517

KenanYusuf opened this issue Nov 20, 2024 · 1 comment
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! customization: theme Centered around the theming features design This is about UI or UX design, please involve a designer

Comments

@KenanYusuf
Copy link
Contributor

KenanYusuf commented Nov 20, 2024

See the following issues:

I propose that in v8, we set a default background color on the data grid to avoid such issues.

We could make it customizable through the theme mixin:

import { createTheme } from '@mui/material/styles';
import type {} from '@mui/x-data-grid/themeAugmentation';

const theme = createTheme({
  mixins: {
    MuiDataGrid: {
+     background: '#340606',
      pinnedBackground: '#340606',
      containerBackground: '#343434',
    },
  },
});
@github-actions github-actions bot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Nov 20, 2024
@KenanYusuf KenanYusuf added breaking change component: data grid This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer RFC Request For Comments customization: theme Centered around the theming features and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Nov 20, 2024
@michelengelen
Copy link
Member

added one more issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! customization: theme Centered around the theming features design This is about UI or UX design, please involve a designer
Projects
None yet
Development

No branches or pull requests

2 participants