-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[l10n] Improve French (fr-FR) locale #12755
Conversation
Localization writing tips ✍️Seems you are updating localization 🌍 files. Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️
Deploy preview: https://deploy-preview-12755--material-ui-x.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! 🙏
@@ -21,7 +21,7 @@ const frFRGrid: Partial<GridLocaleText> = { | |||
// Filters toolbar button text | |||
toolbarFilters: 'Filtres', | |||
toolbarFiltersLabel: 'Afficher les filtres', | |||
toolbarFiltersTooltipHide: 'Cacher les filtres', | |||
toolbarFiltersTooltipHide: 'Masquer les filtres', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change makes sense to me.
But it would be interesting to double-check with @flaviendelangle or @alexfauquette 🤞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm it's more professional
@@ -21,7 +21,7 @@ const frFRGrid: Partial<GridLocaleText> = { | |||
// Filters toolbar button text | |||
toolbarFilters: 'Filtres', | |||
toolbarFiltersLabel: 'Afficher les filtres', | |||
toolbarFiltersTooltipHide: 'Cacher les filtres', | |||
toolbarFiltersTooltipHide: 'Masquer les filtres', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm it's more professional
Co-authored-by: Alexandre Fauquette <[email protected]> Signed-off-by: Flavien DELANGLE <[email protected]>
Signed-off-by: Flavien DELANGLE <[email protected]> Co-authored-by: Flavien DELANGLE <[email protected]> Co-authored-by: Alexandre Fauquette <[email protected]>
Signed-off-by: Flavien DELANGLE <[email protected]> Co-authored-by: Flavien DELANGLE <[email protected]> Co-authored-by: Alexandre Fauquette <[email protected]>
Added missing French data-chart locales keys, that includes:
#3211