Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[l10n] Improve French (fr-FR) locale #12755

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

derek-0000
Copy link
Contributor

@derek-0000 derek-0000 commented Apr 11, 2024

Added missing French data-chart locales keys, that includes:

#3211

@derek-0000 derek-0000 changed the title French locales update Improve French (fr-FR) locale Apr 11, 2024
@derek-0000 derek-0000 marked this pull request as draft April 11, 2024 22:51
@mui-bot
Copy link

mui-bot commented Apr 11, 2024

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running yarn l10n
  • Clean files with yarn prettier.

Deploy preview: https://deploy-preview-12755--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 97d84f7

@derek-0000 derek-0000 changed the title Improve French (fr-FR) locale [l10n] Improve French (fr-FR) locale Apr 11, 2024
@derek-0000 derek-0000 marked this pull request as ready for review April 11, 2024 22:54
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 🙏

@@ -21,7 +21,7 @@ const frFRGrid: Partial<GridLocaleText> = {
// Filters toolbar button text
toolbarFilters: 'Filtres',
toolbarFiltersLabel: 'Afficher les filtres',
toolbarFiltersTooltipHide: 'Cacher les filtres',
toolbarFiltersTooltipHide: 'Masquer les filtres',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change makes sense to me.
But it would be interesting to double-check with @flaviendelangle or @alexfauquette 🤞

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm it's more professional

@LukasTy LukasTy added component: data grid This is the name of the generic UI component, not the React module! l10n localization labels Apr 12, 2024
@@ -21,7 +21,7 @@ const frFRGrid: Partial<GridLocaleText> = {
// Filters toolbar button text
toolbarFilters: 'Filtres',
toolbarFiltersLabel: 'Afficher les filtres',
toolbarFiltersTooltipHide: 'Cacher les filtres',
toolbarFiltersTooltipHide: 'Masquer les filtres',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm it's more professional

packages/x-data-grid/src/locales/frFR.ts Outdated Show resolved Hide resolved
Co-authored-by: Alexandre Fauquette <[email protected]>
Signed-off-by: Flavien DELANGLE <[email protected]>
@LukasTy LukasTy enabled auto-merge (squash) April 12, 2024 12:19
@LukasTy LukasTy mentioned this pull request Apr 12, 2024
@LukasTy LukasTy merged commit d097dc7 into mui:master Apr 12, 2024
15 checks passed
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
Signed-off-by: Flavien DELANGLE <[email protected]>
Co-authored-by: Flavien DELANGLE <[email protected]>
Co-authored-by: Alexandre Fauquette <[email protected]>
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Signed-off-by: Flavien DELANGLE <[email protected]>
Co-authored-by: Flavien DELANGLE <[email protected]>
Co-authored-by: Alexandre Fauquette <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! l10n localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants