Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new slot prop 'providerButton' to the SignInPage component #4584

Open
mkaisercross opened this issue Jan 10, 2025 · 2 comments · May be fixed by #4574
Open

Add new slot prop 'providerButton' to the SignInPage component #4584

mkaisercross opened this issue Jan 10, 2025 · 2 comments · May be fixed by #4574
Assignees
Labels
component: sign-in enhancement This is not a bug, nor a new feature

Comments

@mkaisercross
Copy link

mkaisercross commented Jan 10, 2025

Summary

Should be able to pass custom props to the provider buttons in the SignInPage component. Similarly to the 'submitButton' slot prop we should have a 'providerButton' slot prop.

Examples

    `<SignInPage
      slotProps={{
        providerButton: { variant: 'contained' }
      }}
      providers={providers}
    />`

Motivation

I would like to customize the button variant to 'contained' for all the provider buttons in the SignInPage component e.g. Sign In With Github, Sign In With Facebook, etc.

Search keywords: SignInPage

@mkaisercross mkaisercross added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jan 10, 2025
@bharatkashyap bharatkashyap added enhancement This is not a bug, nor a new feature component: sign-in and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 13, 2025
@bharatkashyap
Copy link
Member

bharatkashyap commented Jan 13, 2025

Makes sense to me 👍🏻 We can do it as part of #4574

oauthButton might be a better name

@bharatkashyap bharatkashyap moved this from Backlog to Planned in MUI Toolpad public roadmap Jan 13, 2025
@bharatkashyap bharatkashyap moved this from Planned to In progress in MUI Toolpad public roadmap Jan 13, 2025
@bharatkashyap bharatkashyap linked a pull request Jan 13, 2025 that will close this issue
@mkaisercross
Copy link
Author

Great! I think oauthButton sounds better, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: sign-in enhancement This is not a bug, nor a new feature
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

2 participants