Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DbfFileException should be renamed to DbfException, #4

Closed
nickolanack opened this issue May 20, 2015 · 5 comments
Closed

DbfFileException should be renamed to DbfException, #4

nickolanack opened this issue May 20, 2015 · 5 comments

Comments

@nickolanack
Copy link
Contributor

DbfFileException is never thrown, but DbfFile.php throws DbfException on line 65, so I assume DbfFileException should in fact be DbfException and DbfException.php renamed DbfFileException.php

@muka
Copy link
Owner

muka commented May 20, 2015

Good catch! Can you provide a PR please?

@nickolanack
Copy link
Contributor Author

hmm, I could rename the file to match the exception thrown, DbfFileException.php to DbfException.php, or i could replace the actual exception thrown (throw DbfException) with throw DbfFileException. I think that the later would be preferred. thoughts?

@muka
Copy link
Owner

muka commented May 20, 2015

Both are ok for me, choose the one that looks better for you

Thanks!

2015-05-20 19:01 GMT+02:00 Nick Blackwell [email protected]:

hmm, I could rename the file to match the exception thrown,
DbfFileException.php to DbfException.php, or i could replace the actual
exception thrown (throw DbfException) with throw DbfFileException. I think
that the later would be preferred. thoughts?


Reply to this email directly or view it on GitHub
#4 (comment).

@nickolanack
Copy link
Contributor Author

Ok, cool. I created a pull request for you.

@muka
Copy link
Owner

muka commented May 20, 2015

Excellent, merged!

@muka muka closed this as completed May 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants