-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DbfFileException should be renamed to DbfException, #4
Comments
Good catch! Can you provide a PR please? |
hmm, I could rename the file to match the exception thrown, DbfFileException.php to DbfException.php, or i could replace the actual exception thrown (throw DbfException) with throw DbfFileException. I think that the later would be preferred. thoughts? |
Both are ok for me, choose the one that looks better for you Thanks! 2015-05-20 19:01 GMT+02:00 Nick Blackwell [email protected]:
|
Ok, cool. I created a pull request for you. |
Excellent, merged! |
DbfFileException is never thrown, but DbfFile.php throws DbfException on line 65, so I assume DbfFileException should in fact be DbfException and DbfException.php renamed DbfFileException.php
The text was updated successfully, but these errors were encountered: