-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding specification of more protocols #137
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very much appreciated! Thanks for the help here!
To prevent any of the discussions on one protocol to block merging another, I would suggest to use separate pull requests for each. That is not a strong opinion though.
I think that adding the basis using this pull request is fine. We can add more information for a specific protocol using other pull requests. @mxinden Also, can you tell me what the binary format of Also, I have made some other pull requests on this and on other repositories. Hope someone can take a look at those too. |
Hope I understand your question correctly @ben221199. As far as I know it is just the utf-8 byte representation. |
w.write_all(encode::usize(bytes.len(), &mut encode::usize_buffer()))?; This code above will prefix the data with an unsigned byte, yes. Are the implementations in this organization authoritive at the moment, or is it still possible to alter the binary format at this time? |
Okay, I think I added enough protocols for now. I think that, except for maybe some slight changes, this pull request can be merged. |
They are used in many production systems, thus I would say yes. |
Above suggestions are applied. |
This pull request adds specifications of more protocols than only
dnsaddr
.I think this pull request should be merged when I have added more, but now it is already possible to see the changes and talk about improvements.