Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ed2k hash type #197

Open
Artoria2e5 opened this issue Sep 14, 2020 · 2 comments
Open

Add ed2k hash type #197

Artoria2e5 opened this issue Sep 14, 2020 · 2 comments

Comments

@Artoria2e5
Copy link

Artoria2e5 commented Sep 14, 2020

ed2k is a protocol that had quite some significance. Compared to torrent-info it has the advantage of identical files always yielding the same hash, since there's nothing tweakable in it. As with the case of torrent, it might have some value in eventually being addressable by ipfs.

A related, stronger hash is the AICH hash tree used by eMule. This is a merkel tree used for error correction, but being built out of SHA-1 it suffers from slightly fewer security complaints.


In the same line of incorporating P2P hashes, Gnutella, G2, Gnunet, Freenet et al. can also each use a type.

@zhangzih4n
Copy link

The same is true for BitTorrent V2 Pieces Root.
It always generates the same hash for the same file

@rvagg
Copy link
Member

rvagg commented Feb 11, 2025

Feel free to add it to the table. As long as it can be properly defined as a hash function and not some funky mash-up then it should be fine to add. Preferably not below 127 as that's the precious single-byte range that we're fairly protective of and reserve for more commonly used identifiers that need the efficiency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@rvagg @Artoria2e5 @zhangzih4n and others