Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "Getting Started" menu to a more suitable place #74

Open
jjnesbitt opened this issue Apr 6, 2020 · 1 comment
Open

Move "Getting Started" menu to a more suitable place #74

jjnesbitt opened this issue Apr 6, 2020 · 1 comment

Comments

@jjnesbitt
Copy link
Member

Currently, the "Getting Started" dialog is a v-menu that wraps the whole template of WorkspaceDialog.vue. This causes a confusing situation, as we're not using the menu in that component really, and it causes redundancies with the template (see 7f64635). It'd be better to put this somewhere more concrete, like Sidebar.vue.

@jtomeck Did you have a particular reason for putting the v-menu in WorkspaceDialog.vue?

@jtomeck
Copy link
Contributor

jtomeck commented Apr 7, 2020

Inexperience is probably the best explanation I could give you. Since I wanted it positioned next to the new workspace button, I think putting it there auto positioned it for me. I'm open to better ways of doing it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants