Integration tests refactor for uniformity #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmatudor
changed the title
cosmatudor
changed the base branch from
main
to
post-audit-testS-refactor-part1
sstanculeanu
previously approved these changes
Nov 12, 2024
Base automatically changed from
post-audit-testS-refactor-part1
to
feat/v3-audit-tests
November 14, 2024 09:23
cosmatudor
dismissed
sstanculeanu’s stale review
The base branch was changed.
| handler.checkEthTxResult(ctx, tx.Hash()) | ||
| } | ||
|
|
||
| var tx *types.Transaction |
There was a problem hiding this comment.
I think we still need this early exit:
if operation.ValueToTransferToMvx == nil {
return
}it was found on L458, on the old code
There was a problem hiding this comment.
I thought it would be cleaner to keep the logic for deposits isolated within SendDepositTransactionFromEthereum. The validation check is now performed beforehand (L468 from TestSetup.go)
|
|
||
| require.NoError(handler, err) | ||
| // SettleBatchOnEthereum commits as many blocks as needed to settle the batch on Ethereum | ||
| func (handler *EthereumHandler) SettleBatchOnEthereum() { |
sstanculeanu
approved these changes
Nov 18, 2024
iulianpascalau
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.