Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests refactor for uniformity #372

Merged

Conversation

cosmatudor
Copy link

No description provided.

@cosmatudor cosmatudor changed the title Integration tests refactor for uniformity between Mvx side and Eth side Integration tests refactor for uniformity Nov 4, 2024
@cosmatudor cosmatudor changed the base branch from main to post-audit-testS-refactor-part1 November 4, 2024 14:56
sstanculeanu
sstanculeanu previously approved these changes Nov 12, 2024
Base automatically changed from post-audit-testS-refactor-part1 to feat/v3-audit-tests November 14, 2024 09:23
@cosmatudor cosmatudor dismissed sstanculeanu’s stale review November 14, 2024 09:23

The base branch was changed.

handler.checkEthTxResult(ctx, tx.Hash())
}

var tx *types.Transaction
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need this early exit:

if operation.ValueToTransferToMvx == nil {
    return
}

it was found on L458, on the old code

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it would be cleaner to keep the logic for deposits isolated within SendDepositTransactionFromEthereum. The validation check is now performed beforehand (L468 from TestSetup.go)


require.NoError(handler, err)
// SettleBatchOnEthereum commits as many blocks as needed to settle the batch on Ethereum
func (handler *EthereumHandler) SettleBatchOnEthereum() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cosmatudor cosmatudor merged commit 4b1aa1f into feat/v3-audit-tests Nov 18, 2024
4 checks passed
@cosmatudor cosmatudor deleted the integration-tests-refactor-for-uniformity branch November 18, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants