-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration tests refactor for uniformity #372
Integration tests refactor for uniformity #372
Conversation
The base branch was changed.
handler.checkEthTxResult(ctx, tx.Hash()) | ||
} | ||
|
||
var tx *types.Transaction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we still need this early exit:
if operation.ValueToTransferToMvx == nil {
return
}
it was found on L458, on the old code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it would be cleaner to keep the logic for deposits isolated within SendDepositTransactionFromEthereum
. The validation check is now performed beforehand (L468 from TestSetup.go)
|
||
require.NoError(handler, err) | ||
// SettleBatchOnEthereum commits as many blocks as needed to settle the batch on Ethereum | ||
func (handler *EthereumHandler) SettleBatchOnEthereum() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
No description provided.