Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not automatically install Rust on "contract build" #371

Closed
andreibancioiu opened this issue Dec 10, 2023 · 1 comment
Closed

Do not automatically install Rust on "contract build" #371

andreibancioiu opened this issue Dec 10, 2023 · 1 comment
Assignees

Comments

@andreibancioiu
Copy link
Contributor

andreibancioiu commented Dec 10, 2023

Should overcome issues such as:

Should also ameliorate #338, since the underlying error of not being able to install sc-meta will not be hidden anymore by the error that happens at the time of running contract build: No such file or directory: sc-meta.

Additionally, do not perform Rust installation / installation check on mxpy contract templates. Currently, the output of mxpy contract templates is:

Found extra arguments in mxpy.json. Final arguments: ['contract', 'templates']
INFO     projects.templates: Checking if the necessarry dependencies are installed.                           templates.py:35
╭───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ We recommend using rust nightly-2023-05-26. If you'd like to overwrite your current version please run `mxpy deps install │
│ rust --overwrite`.                                                                                                        │
╰───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
INFO     modules: install: key=rust, tag=nightly-2023-05-26, overwrite=False                                   modules.py:283
INFO     modules: which ...
INFO     myprocess: run_process: ['sc-meta', 'templates'], in folder: None                                    myprocess.py:12
INFO     myprocess: Successful run. Output:                                                                   myprocess.py:16
...

Instead, perhaps, do ensure_rust() or something similar, that only checks for rust, without installing it.

@popenta
Copy link
Contributor

popenta commented Dec 14, 2023

mxpy does not automatically install Rust on any contract operation.
Fixed in PR #376.

@popenta popenta closed this as completed Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants