Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Formatting / linting #313

Closed
reckter opened this issue Dec 30, 2024 · 3 comments
Closed

Code Formatting / linting #313

reckter opened this issue Dec 30, 2024 · 3 comments

Comments

@reckter
Copy link
Contributor

reckter commented Dec 30, 2024

This is more of a "probing question":
My IDE of choice (webstorm), formats code a bit different than the current standard here.

In order to not format all over the place, I need to take care to only commit, what I actually changed.
A (imo) simple and effective solution, would be to add prettier to this project.
If wanted, I can do that, and try to keep the style as close to the current one.
But only if it's wanted from others as well, it might lower barrier of entry a bit, but it of course will add developer and package complexity.

What do you think? (I don't mind not adding prettier at all, consider this more of a "this will make life easier for me, so it might make it easier for other people too")

@TodePond
Copy link
Contributor

i think adding a prettier config file to root would be a good idea

@reckter
Copy link
Contributor Author

reckter commented Dec 30, 2024

Done in #314

@reckter
Copy link
Contributor Author

reckter commented Jan 2, 2025

Closing, with #319 now open :)

@reckter reckter closed this as completed Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants