Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

with_mock() is going away #174

Closed
hadley opened this issue Jan 10, 2025 · 1 comment · Fixed by #176
Closed

with_mock() is going away #174

hadley opened this issue Jan 10, 2025 · 1 comment · Fixed by #176
Assignees
@munterfi
Labels
dependencies Pull requests that update a dependency file

Comments

@hadley
Copy link

hadley commented Jan 10, 2025

This is a heads up to let you know that with_mock() is deprecated and will be made defunct soon. The API functions that made it work are being removed in R 4.5.0, so we'd suggest that you switch to with_mocked_bindings() instead.
@munterfi munterfi self-assigned this Feb 15, 2025
@munterfi munterfi linked a pull request Feb 15, 2025 that will close this issue
test: replace deprecated with_mock() with with_mocked_bindings() … #176
Merged
@munterfi munterfi added the dependencies Pull requests that update a dependency file label Feb 17, 2025
@munterfi
Copy link
Owner

Thanks @hadley for reporting! The tests are migrated to use with_mocked_bindings().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@munterfi munterfi

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: replace deprecated with_mock() with with_mocked_bindings() … munterfi/hereR
2 participants
@hadley @munterfi