[RFC] Add SaveFilenameFormat = 2 to match original rom filename

[YourWishes]

Requesting a new SaveFilenameFormat to have the save file name match that of the ROM name just with the extension changed (remove .z64 and change to .srm or what have you). Here is my proposed change, would need to check if ROM_PARAMS.goodname needs extension removed but wanted to see if there's any concerns with file name lengths.

    if (format == 0) {
        snprintf(filename, 256, "%s", ROM_PARAMS.headername);
    } else /* if (format == 1) */ {
        if (strstr(ROM_SETTINGS.goodname, "(unknown rom)") == NULL) {
            snprintf(filename, 256, "%.32s-%.8s", ROM_SETTINGS.goodname, ROM_SETTINGS.MD5);
        } else if (ROM_HEADER.Name[0] != 0) {
            snprintf(filename, 256, "%s-%.8s", ROM_PARAMS.headername, ROM_SETTINGS.MD5);
        } else {
            snprintf(filename, 256, "unknown-%.8s", ROM_SETTINGS.MD5);
        }
    }

to

    if (format == 0) {
        snprintf(filename, 256, "%s", ROM_PARAMS.headername);
    } else if (format == 1) {
        if (strstr(ROM_SETTINGS.goodname, "(unknown rom)") == NULL) {
            snprintf(filename, 256, "%.32s-%.8s", ROM_SETTINGS.goodname, ROM_SETTINGS.MD5);
        } else if (ROM_HEADER.Name[0] != 0) {
            snprintf(filename, 256, "%s-%.8s", ROM_PARAMS.headername, ROM_SETTINGS.MD5);
        } else {
            snprintf(filename, 256, "unknown-%.8s", ROM_SETTINGS.MD5);
        }
    } else /* if format( == 2) */ {
        snprintf(filename, 256, "%.256s", ROM_SETTINGS.goodname);
    }

in main.c

[Rosalie241]

What's your end goal with this change? the ROM_SETTINGS.goodname isn't the filename, it's a name retrieved from the ROM database which uses the MD5 to detect which one matches.

[YourWishes]

I ah thanks for clarifying.
End goal would be to have the save file match the rom basename exactly, so that;
Legend of Zelda, The - Ocarina of Time.z64
would have a save file
Legend of Zelda, The - Ocarina of Time.srm
or whatever save extension the ROM uses.

I know some implementations do this already e.g. libretro, but would like to have a native option.