Fix step reference in condition on finalize snapshot

muselab-d2x · Sep 15, 2024 · 1859f39 · 1859f39
1 parent a1f5343
commit 1859f39
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/.github/workflows/feature-test-2gp-snapshot.yml b/.github/workflows/feature-test-2gp-snapshot.yml
@@ -196,15 +196,15 @@ jobs:
 
             - name: Finalize Snapshot Creation
               id: finalize_snapshot
-              if: inputs.create_pr_snapshot == true || (inputs.create_failure_snapshot == true && job.status != 'success')
+              if: inputs.create_pr_snapshot == true && steps.start_snapshot|| (inputs.create_failure_snapshot == true && job.status != 'success')
               env:
                   GITHUB_TOKEN: ${{ secrets.github-token }}
               run: |
 
                   # If the snapshot creation task was run, finalize the snapshot
-                  if [[ "${{ inputs.create_pr_snapshot }}" == "true" && -n "${{ steps.start_snapshot_creation.outputs.SNAPSHOT_ID }}" ]]; then
+                  if [[ "${{ inputs.create_pr_snapshot }}" == "true" && -n "${{ steps.start_snapshot.outputs.SNAPSHOT_ID }}" ]]; then
                     cci task run github_pull_request_snapshot \
-                        --snapshot-id "${{ steps.start_snapshot_creation.outputs.SNAPSHOT_ID }}" \
+                        --snapshot-id "${{ steps.start_snapshot.outputs.SNAPSHOT_ID }}" \
                         --build-success "${{ job.status == 'success' }}" \
                         --build-fail-tests "${{ contains(steps.feature_test.outputs.*, 'ApexTestException') }}" \
                         --snapshot-is-packaged true \