Skip to content

Commit

Permalink
Update github actions to fix deprecation warnings
Browse files Browse the repository at this point in the history
Warnings abou node 16 deprecation and moving to node20. Also,
upload artifact ation needs updating to v4, with some warning about
breaking changes.

See:
- https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
- https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
    - breaking changes; https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes
  • Loading branch information
acrespo committed May 3, 2024
1 parent ac4d635 commit 6cdac4d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/build-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,16 +36,16 @@ jobs:
outputs: apk

- name: Upload APK
uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # Matches tag v3.1.3
# https://github.com/actions/upload-artifact/releases/tag/v3.1.3
uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # Matches tag v4.3.3
# https://github.com/actions/upload-artifact/releases/tag/v4.3.3

with:
name: apk
path: apk/apolloui-prod-release-unsigned.apk

- name: Upload mapping
uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # Matches tag v3.1.3
# https://github.com/actions/upload-artifact/releases/tag/v3.1.3
uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # Matches tag v4.3.3
# https://github.com/actions/upload-artifact/releases/tag/v4.3.3

with:
name: mapping
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ jobs:
outputs: apk

- name: Upload APK
uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # Matches tag v3.1.3
# https://github.com/actions/upload-artifact/releases/tag/v3.1.3
uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # Matches tag v4.3.3
# https://github.com/actions/upload-artifact/releases/tag/v4.3.3

with:
name: apk
Expand Down

0 comments on commit 6cdac4d

Please sign in to comment.