From 6cdac4d295d1eff63743a71b95f545e075f7d9ed Mon Sep 17 00:00:00 2001 From: acrespo Date: Fri, 3 May 2024 18:57:30 -0300 Subject: [PATCH 1/2] Update github actions to fix deprecation warnings Warnings abou node 16 deprecation and moving to node20. Also, upload artifact ation needs updating to v4, with some warning about breaking changes. See: - https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ - https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ - breaking changes; https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes --- .github/workflows/build-release.yml | 8 ++++---- .github/workflows/pr.yml | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build-release.yml b/.github/workflows/build-release.yml index 1f110618..0c78152e 100644 --- a/.github/workflows/build-release.yml +++ b/.github/workflows/build-release.yml @@ -36,16 +36,16 @@ jobs: outputs: apk - name: Upload APK - uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # Matches tag v3.1.3 - # https://github.com/actions/upload-artifact/releases/tag/v3.1.3 + uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # Matches tag v4.3.3 + # https://github.com/actions/upload-artifact/releases/tag/v4.3.3 with: name: apk path: apk/apolloui-prod-release-unsigned.apk - name: Upload mapping - uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # Matches tag v3.1.3 - # https://github.com/actions/upload-artifact/releases/tag/v3.1.3 + uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # Matches tag v4.3.3 + # https://github.com/actions/upload-artifact/releases/tag/v4.3.3 with: name: mapping diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 2c3ab40a..6bb03224 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -37,8 +37,8 @@ jobs: outputs: apk - name: Upload APK - uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # Matches tag v3.1.3 - # https://github.com/actions/upload-artifact/releases/tag/v3.1.3 + uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # Matches tag v4.3.3 + # https://github.com/actions/upload-artifact/releases/tag/v4.3.3 with: name: apk From 85cf978abd8535e3822651bd02d103117bcd78da Mon Sep 17 00:00:00 2001 From: acrespo Date: Fri, 3 May 2024 19:19:49 -0300 Subject: [PATCH 2/2] Update gradle wrapper validation action Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: gradle/wrapper-validation-action@55e685c48d84285a5b0418cd094606e199cca3b6. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/. Also, As of v3 this action has been superceded by gradle/actions/wrapper-validation. Any workflow that uses gradle/wrapper-validation-action@v3 will transparently delegate to gradle/actions/wrapper-validation@v3. Users are encouraged to update their workflows to use: `uses: gradle/actions/wrapper-validation@v3` --- .github/workflows/pr.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 6bb03224..9b417b22 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -20,8 +20,8 @@ jobs: # https://github.com/actions/checkout/releases/tag/v4.1.1 - name: Validate Gradle wrapper - uses: gradle/wrapper-validation-action@55e685c48d84285a5b0418cd094606e199cca3b6 # Matches tag v1.0.5 - # https://github.com/gradle/wrapper-validation-action/releases/tag/v1.0.5 + uses: gradle/actions/wrapper-validation@db19848a5fa7950289d3668fb053140cf3028d43 # Matches tag v3 + # https://github.com/gradle/actions/releases/tag/v3 - name: Create output dir run: |