Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable/disable subtitles on connectedCallback #777

Open
luwes opened this issue Dec 4, 2023 · 0 comments
Open

Re-enable/disable subtitles on connectedCallback #777

luwes opened this issue Dec 4, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@luwes
Copy link
Contributor

luwes commented Dec 4, 2023

related to #775

Subtitles are forcefully disabled on disconnectedCallback to prevent memory leaks.
We should remember the state and re-apply on connectedCallback

@luwes luwes self-assigned this Jan 12, 2024
@luwes luwes added the enhancement New feature or request label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant