Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuring all the configurable envs from helm values #5

Open
edevosc2c opened this issue Oct 30, 2024 · 0 comments
Open

Allow configuring all the configurable envs from helm values #5

edevosc2c opened this issue Oct 30, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@edevosc2c
Copy link
Collaborator

It is not good to handle the extra config of the application using an array because you can't benefit from the default parameters.

Example:

extraEnv:
  - name: MVIEWERSTUDIO_URL_PATH_PREFIX
    value: mviewerstudio

It's better to allow configuring all the envs from a helm value: https://github.com/mviewer/mviewerstudio/blob/master/docker/readme.md?plain=1#L6-L12
@edevosc2c edevosc2c added the enhancement New feature or request label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edevosc2c