Merge pull request #33 from myDevicesIoT/fix/refactor-error-message

fix: refactor error message forwarding
myDevicesIoT · Mar 25, 2021 · ee70e0e · ee70e0e
2 parents 240a866 + cdffecb
commit ee70e0e
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 192 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -4,8 +4,6 @@
     "prettier"
   ],
 
-  "parser": "babel-eslint",
-
   "parserOptions": {
     "ecmaVersion": 2018,
     "sourceType": "module"

diff --git a/lib/Request.js b/lib/Request.js
@@ -233,7 +233,11 @@ class Request {
     if (error instanceof CoreError) {
       return error;
     }
-    const message = error.response?.body?.message || error.message || error;
+
+    const message =
+      error.response && error.response.body && error.response.body.message
+        ? error.response.body.message
+        : error.message || error;
 
     error = new CoreError(message, { statusCode: error.status });
     return error;

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -19,14 +19,13 @@
     "superagent": "^4.1.0"
   },
   "devDependencies": {
-    "babel-eslint": "^10.1.0",
     "code": "^5.2.4",
     "dotenv": "^6.2.0",
     "eslint": "^6.8.0",
     "eslint-config-prettier": "^6.10.1",
+    "eslint-plugin-prettier": "^3.1.2",
     "eslint-plugin-import": "^2.16.0",
     "eslint-plugin-mocha": "^5.2.1",
-    "eslint-plugin-prettier": "^3.1.2",
     "mocha": "^7.1.1",
     "nock": "^12.0.2",
     "prettier": "^1.16.4",