Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saveSession and loadSession do not accept file:// URI's. #60

Closed
Vali-98 opened this issue Jun 11, 2024 · 0 comments · Fixed by #66
Closed

saveSession and loadSession do not accept file:// URI's. #60

Vali-98 opened this issue Jun 11, 2024 · 0 comments · Fixed by #66
Labels
bug Something isn't working

Comments

@Vali-98
Copy link
Contributor

Vali-98 commented Jun 11, 2024

Unlike initLlama, saveSession and loadSession both do not accept paths prefixed with file://.

Though this is a minor issue, it does hurt users of expo-filesystem which always prefixes its documentDirectory with file://, unlike ReactNativeBlobUtil used in the example app. Attempting to use documentDirectory from expo-filesystem results in a file not found error.

At the moment, this is simply fixed by replacing file:// with an empty string, however, consistency between initLlama, saveSession and loadSession path parsing would be ideal.

@jhen0409 jhen0409 added the bug Something isn't working label Jun 15, 2024
@jhen0409 jhen0409 linked a pull request Jul 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants