Skip to content
This repository has been archived by the owner on Oct 24, 2024. It is now read-only.

TLD registration #79

Merged
merged 8 commits into from
Sep 14, 2023
Merged

TLD registration #79

merged 8 commits into from
Sep 14, 2023

Conversation

yujiym
Copy link
Contributor

@yujiym yujiym commented Sep 12, 2023

PR for #66

  • Added TLD registration
    • just registration, no fee logic implementation
    • test

@yujiym yujiym requested a review from taryune September 12, 2023 01:29
@yujiym yujiym marked this pull request as ready for review September 12, 2023 01:29
taryune
taryune suggested changes Sep 12, 2023
View reviewed changes
Copy link
Member

@taryune taryune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add missing argument name and registrationPeriodInYear

rename cli/tx_register_domain.go to tx_register_second_level_domain

x/registry/client/cli/tx_register_top_level_domain.go Show resolved Hide resolved
x/registry/types/message_register_top_level_domain.go Outdated Show resolved Hide resolved
x/registry/types/message_register_top_level_domain_test.go Show resolved Hide resolved
@yujiym yujiym requested a review from taryune September 13, 2023 07:41
@yujiym yujiym requested a review from taryune September 13, 2023 09:15
taryune
taryune approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@taryune taryune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yujiym yujiym merged commit aa9feba into main Sep 14, 2023
2 checks passed
@yujiym yujiym deleted the feature/tld-registration branch September 14, 2023 10:01
@yujiym yujiym restored the feature/tld-registration branch September 28, 2023 10:39
@yujiym yujiym deleted the feature/tld-registration branch September 28, 2023 10:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@taryune taryune taryune approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yujiym @taryune