Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PoolKeeper.sol] Incorrect keeper reward calculation #332

Closed
sporejack opened this issue Feb 25, 2022 · 2 comments · May be fixed by #381
Closed

[PoolKeeper.sol] Incorrect keeper reward calculation #332

sporejack opened this issue Feb 25, 2022 · 2 comments · May be fixed by #381
Assignees
@sporejack
Labels
bug Something isn't working spearbit

Comments

@sporejack
Copy link
Contributor

Description

See spearbit-audits/tracer#11.

Mitigation

See spearbit-audits/tracer#11.
@sporejack sporejack added bug Something isn't working spearbit labels Feb 25, 2022
@sporejack sporejack self-assigned this Feb 25, 2022
@sporejack
Copy link
Contributor Author

@mynameuhh Is this test basically checking keeper rewards?

https://github.com/tracer-protocol/perpetual-pools-contracts/blob/c289429af6fa2702fdfedbc916e2a64c08b95966/test/PoolKeeper/performUpkeep/basicFunctions.spec.ts#L185-L224

@CalabashSquash
Copy link
Contributor

Yeah it is

@sporejack sporejack mentioned this issue Mar 4, 2022
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sporejack sporejack

Labels
bug Something isn't working spearbit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrect keeper reward scaling mycelium-ethereum/perpetual-pools-contracts
2 participants
@CalabashSquash @sporejack