Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unnecessary psalm suppress docblock #149

Open
Ilyes512 opened this issue Jul 27, 2021 · 0 comments · May be fixed by #151
Open

Removing unnecessary psalm suppress docblock #149

Ilyes512 opened this issue Jul 27, 2021 · 0 comments · May be fixed by #151

Comments

@Ilyes512
Copy link

Ilyes512 commented Jul 27, 2021

This is more of a FYI...

I am running psalm on my own project with the --find-unused-psalm-suppress flag and even though I told psalm to ignore the vendor dir it still showed me this error:

ERROR: UnusedPsalmSuppress - vendor/myclabs/php-enum/src/Enum.php:72:29 - This suppression is never used (see https://psalm.dev/207)
/** @psalm-suppress ImplicitToStringCast assertValidValueReturningKey returns always a string but psalm has currently an issue here */

So in other words I think this line can be removed: https://github.com/myclabs/php-enum/blob/master/src/Enum.php#L72

@simPod simPod linked a pull request Aug 3, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant